osdb-1-claude-opusplan

3 Commits

Include renames

Author SHA1 Message Date

julia 5e4120a027 update: consolidate import instructions, expand supported image directories in import_fruits, and add backend .env inclusion in Makefile 2026-06-22 13:19:51 +02:00

Author	SHA1	Message	Date
julia	5e4120a027	update: consolidate import instructions, expand supported image directories in `import_fruits`, and add backend `.env` inclusion in `Makefile`	2026-06-22 13:19:51 +02:00
juliaandClaude Sonnet 4.6	7fc8204924	fix: apply code-review findings to import_fruits script and tests - find_images: verify exact fruit_id prefix (stem-parse before _s0.) to prevent cross-fruit image contamination (e.g. mitschurins steals mitschurins_fruchtbare images) - DATA_DIR uses os.path.abspath to handle symlinks / relative invocation - counts["images"] derived from IMAGE_DIRS constant, not hardcoded keys - counts["warnings"] incremented on missing-id/name skip (was missing) - UPSERT preserves existing comment (comment = fruits.comment, not NULL) - Print summary and rollback moved inside try/except to avoid NameError - Remove dead XML_PATH constant - Tests: add tearDown to clean up tmpdir; fix vacuous _tn exclusion test to include positive-control _s0 file; add prefix-collision regression test Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-17 13:38:05 +02:00
juliaandClaude Sonnet 4.6	4d4c5f399f	feat: import fruit DB from XML — scripts/import_fruits.py (story #03 ) Adds a repeatable Python import script that populates fruits, fruit_synonyms, and fruit_images from 03-data/obstsorten.xml and the three image directories. Idempotent: deletes synonyms and images per fruit before re-inserting; upserts fruit row by osdb_number. Reads DATABASE_URL from env. - map_typ: 23 XML typ codes → 17-value fruit_type enum; aggregate types coerced with logged warning; typ='p' (2 entries) mapped to Pfirsiche - parse_synonyms: comma-split with whitespace/newline strip, empty filter - parse_date: YYYYMMDD → date, fallback None → DB default NOW() - find_images: globs {id}__s0. across einzelfruechte/blueten/baume dirs - 42 unit tests (no DB required) cover all mapping, parsing, and glob logic - Makefile test target extended to include Python test suite - 03-data/ and obstsorten.zip added to .gitignore (large binary data) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-06-17 13:24:29 +02:00

juliaandClaude Sonnet 4.6

7fc8204924

fix: apply code-review findings to import_fruits script and tests

- find_images: verify exact fruit_id prefix (stem-parse before _s0.) to
  prevent cross-fruit image contamination (e.g. mitschurins steals
  mitschurins_fruchtbare images)
- DATA_DIR uses os.path.abspath to handle symlinks / relative invocation
- counts["images"] derived from IMAGE_DIRS constant, not hardcoded keys
- counts["warnings"] incremented on missing-id/name skip (was missing)
- UPSERT preserves existing comment (comment = fruits.comment, not NULL)
- Print summary and rollback moved inside try/except to avoid NameError
- Remove dead XML_PATH constant
- Tests: add tearDown to clean up tmpdir; fix vacuous _tn exclusion test
  to include positive-control _s0 file; add prefix-collision regression test

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-06-17 13:38:05 +02:00

juliaandClaude Sonnet 4.6

4d4c5f399f

feat: import fruit DB from XML — scripts/import_fruits.py (story #03 )

Adds a repeatable Python import script that populates fruits, fruit_synonyms,
and fruit_images from 03-data/obstsorten.xml and the three image directories.
Idempotent: deletes synonyms and images per fruit before re-inserting; upserts
fruit row by osdb_number. Reads DATABASE_URL from env.

- map_typ: 23 XML typ codes → 17-value fruit_type enum; aggregate types coerced
  with logged warning; typ='p' (2 entries) mapped to Pfirsiche
- parse_synonyms: comma-split with whitespace/newline strip, empty filter
- parse_date: YYYYMMDD → date, fallback None → DB default NOW()
- find_images: globs {id}_*_s0.* across einzelfruechte/blueten/baume dirs
- 42 unit tests (no DB required) cover all mapping, parsing, and glob logic
- Makefile test target extended to include Python test suite
- 03-data/ and obstsorten.zip added to .gitignore (large binary data)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

2026-06-17 13:24:29 +02:00